chatterino2 icon indicating copy to clipboard operation
chatterino2 copied to clipboard

Add a filter for channels you want to save logs for

Open zneix opened this issue 5 years ago • 12 comments

Is your feature request related to a problem? Please describe.

I have a lot of channels joined in my Chatterino. I mod some of those, logging chat history is often really helpful, but I often end up having too many useless logs for big channels like forsen and I obviously don't need those, so that spam only takes more of my disk space.


Describe the solution you'd like

I thought of few things:

  • A table, may be a similar thing like the one with Highlights
  • Input field(s) that will let you type channel names separated by commas (e.g. "pajlada, zneix, normiestreamer123,")
  • In case you have a lot of those channels, then you can maybe include an option to select .txt file with channel names separated by newlines or commas

Selected channels would be logged, others not. There could be also a tick box for enabling/disabling channel filtering in this feature.


Describe alternatives you've considered

There might be also an option to only "blacklist" certain channels but I think it is not that necessary to have.


Additional context Not really, Have a good Christmas :)

zneix avatar Dec 23 '19 11:12 zneix

If this is implemented, it might make sense to provide an interface for generic channel-specific settings. Options like "Notify when live" or "Mute highlight sound" could then also be consolidated into a common place. Designing such an interface might be quite a bit of work though.

leon-richardt avatar Dec 23 '19 11:12 leon-richardt

I don't think it would be that hard, you could get all open channels, create a table and have tabs with checkboxes for each of the settings

apa420 avatar Dec 23 '19 11:12 apa420

I don't think it would be that hard, you could get all open channels, create a table and have tabs with checkboxes for each of the settings

The "quite a bit of work" was referring to generic channel-specific settings. This feature in isolation shouldn't be too hard, I agree.

leon-richardt avatar Dec 23 '19 11:12 leon-richardt

So you mean reworking the way the current implementations are done in a new common place for it? Just using the ones we have now and connecting the checkboxes would be easy.

edit: maybe I misunderstand

apa420 avatar Dec 23 '19 11:12 apa420

This issue might not be the right place to have this discussion, but essentially yes.

For example, the channel-specific settings "Notify when live" or "Mute highlight sound" are currently implemented in the NotificationController and PingController, respectively. I'm wondering whether it would make sense to introduce a new interface for managing channel-specific settings in a common place rather than spreading functionality over different classes. In that case, this feature request could be implemented there.

I'm open to discussion though.

leon-richardt avatar Dec 23 '19 11:12 leon-richardt

I do think talking implementations of issues should be talked in the issue, where else would it be?

So yea that's what I was trying to get at.

It does make sense to introduce such an interface since it would also make it easier to implement some new channel-spefic feature.

apa420 avatar Dec 23 '19 11:12 apa420

I do think talking implementations of issues should be talked in the issue, where else would it be?

Maybe in a separate discussion thread as this would not only concern this specific feature.

leon-richardt avatar Dec 23 '19 11:12 leon-richardt

I guess that's fair

apa420 avatar Dec 23 '19 11:12 apa420

Any news on this feature request ? I was about to post about it.

pijcab avatar Jun 20 '20 23:06 pijcab

Nope, but since I created this issue I've improved my c++ skills a bit, so I can try implementing that.
I think that another setting in Moderation page should do the thing for this issue, however. When I look back to first @leon-richardt 's comment I'm not sure whether I should start trying to make that or just wait for a feature that will cover channel-specific settings.

I'll try to make something anyway, but I do like the idea of channel-specific settings a lot!

zneix avatar Jun 20 '20 23:06 zneix

@zneix I'd say do it, good practice for your skills AND (not 100% sure of this but) your code could be reused for the unified channel-specific settings if it gets implemented down the road.

pijcab avatar Jun 21 '20 00:06 pijcab

Yes, I agree as well. I don't think it makes sense to postpone this for a feature that might never get implemented at all (or that is far away, at least).

Also, I feel like this should be fairly easy to port to channel-specific settings when/if they are added at some point in the feature.

leon-richardt avatar Jun 21 '20 10:06 leon-richardt

Will this be implemented? Any updates?

stereotypicaldev avatar Dec 20 '22 12:12 stereotypicaldev

Will this be implemented? Any updates?

No update - we would accept a PR

pajlada avatar Dec 22 '22 13:12 pajlada