NextChat icon indicating copy to clipboard operation
NextChat copied to clipboard

Remove default ENV to allow user provide environment variables via env files

Open ileodo opened this issue 1 year ago • 5 comments

NextJS app allow user define environment variables by providing a .env.local file in /app/.

Those related lines in the Dockerfile are setting values to the environment variables, which will be passed in as process.env, which ranked as the top one in the loading order

This PR is removing these default variables so that user can just mount a .env.local file to set environment variable, which can avoid include the sensitive information in the docker-compose file.

ileodo avatar Jan 25 '24 21:01 ileodo

@ileodo is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 25 '24 21:01 vercel[bot]

Your build has completed!

Preview deployment

github-actions[bot] avatar Jan 25 '24 22:01 github-actions[bot]

@ileodo I'm assuming you are going to mount .env.local file inside the docker container so that NextJS would load the env by default?

kaaanata avatar Jan 26 '24 03:01 kaaanata

yep.

ileodo avatar Jan 26 '24 21:01 ileodo

any chance to get an approval on this? thx

ileodo avatar Feb 04 '24 13:02 ileodo