jQuery.ProfanityFilter icon indicating copy to clipboard operation
jQuery.ProfanityFilter copied to clipboard

Usage of common localStorage variable UID

Open rvbz opened this issue 5 years ago • 3 comments

Hello,

The script makes usage of general localStorage variable names like "uid" which can present a problem when using with different other plugins and scripts. It's always a good practice to set those variable names with specific and almost a unique way to avoid clashing with other scripts, e.g. "profanityFilter_uid"

rvbz avatar Dec 06 '19 14:12 rvbz

have you found this to actually conflict?

ChaseFlorell avatar Dec 06 '19 14:12 ChaseFlorell

Of course, otherwise I wouldn't be posting an issue.

rvbz avatar Dec 06 '19 14:12 rvbz

can you describe your issue? the var uid is scoped to the localStorageIsEnabled function. But if you're having an issue, I'll happily take a PR.

ChaseFlorell avatar Dec 06 '19 14:12 ChaseFlorell