material-github icon indicating copy to clipboard operation
material-github copied to clipboard

Issue with "Available filters" heading in notifications

Open LunaLycan287 opened this issue 3 years ago • 2 comments

Currently the headline looks like this with the text having no padding to the side: grafik

In normal github this is okay because it's all white: grafik

Issue in line 165 "div.border.rounded-1" overwrites the bg color to bg-2 instead of white which is bg-3

My possible solutions:

  1. Change everything to "white" replacement by setting js-notification-search-autocomplete-dropdown to bg-3 grafik Will have to adjust text color of texts & it is not easy to set apart from page background

  2. Change background to bg-2 too grafik Might have to adjust "Available filters" text color?

  3. Adjust padding grafik Maybe would have to add rounded borders? Overall doesn't seem nice still

I would personally prefer the 2nd Option. Do you think the text color should also be adjusted? if yes to what?

LunaLycan287 avatar Nov 20 '20 00:11 LunaLycan287

Hi @Moonwolf287, second option is great!

CharlieEtienne avatar Nov 20 '20 08:11 CharlieEtienne

@Moonwolf287 are you going to make a PR for that one?

CharlieEtienne avatar Dec 04 '20 10:12 CharlieEtienne