material-github
material-github copied to clipboard
Issue with "Available filters" heading in notifications
Currently the headline looks like this with the text having no padding to the side:
In normal github this is okay because it's all white:
Issue in line 165 "div.border.rounded-1" overwrites the bg color to bg-2 instead of white which is bg-3
My possible solutions:
-
Change everything to "white" replacement by setting js-notification-search-autocomplete-dropdown to bg-3 Will have to adjust text color of texts & it is not easy to set apart from page background
-
Change background to bg-2 too Might have to adjust "Available filters" text color?
-
Adjust padding Maybe would have to add rounded borders? Overall doesn't seem nice still
I would personally prefer the 2nd Option. Do you think the text color should also be adjusted? if yes to what?
Hi @Moonwolf287, second option is great!
@Moonwolf287 are you going to make a PR for that one?