xcparse icon indicating copy to clipboard operation
xcparse copied to clipboard

Added numbering to the filenames of the attachments that are extracted

Open bennet3 opened this issue 5 years ago • 2 comments

Change Description: Added numbering to the filenames of the attachments that are extracted. I needed the attachments to be numbered so that I can see the order that the screenshots happened for UI testing and debugging. Test Plan/Testing Performed: Verified that the numbering of the attachments works by running on several .xcresult files from my own project

bennet3 avatar Dec 04 '19 03:12 bennet3

This will result in different filenames, so depending on the release cycle of the project, it may be considered a breaking change. It might be good to disable the indexes by default and enable them with a command line argument, or save this change until a major semver release.

rpendleton avatar Dec 04 '19 20:12 rpendleton

Assigning to myself. We're looking at adding a feature in order to created animated PNGs from the test failure screenshots & to do that, we'll need to create the ordered screenshots feature. Additionally, to support both that & this PR, xcparse has to be re-worked to do a DFS rather than BFS of the tree for attachments/screenshots. While this current PR will look like it's in order most of the time, it can be out of order due to the BFS for attachments rather than DFS.

abotkin-cpi avatar Jan 13 '20 23:01 abotkin-cpi