bootbot icon indicating copy to clipboard operation
bootbot copied to clipboard

Published 20 hours ago • verified publisher icon Charca

add typings

Open adityapurwa opened this issue 7 years ago • 5 comments

Added typescript typings so typescript user can use this library with ease.

adityapurwa avatar Feb 18 '18 18:02 adityapurwa

Any update on this?

davidfrtala avatar May 17 '18 13:05 davidfrtala

@davidfrtala Just waiting for @Charca to confirm on this, I personally used TypeScript extensively and having typings would help me .

adityapurwa avatar May 28 '18 07:05 adityapurwa

@adityapurwa have you also updated the typings for most recent version? There are also some issues from what I see. For instance in SendApi class declaration, most of the send* functions returns void which is wrong, because they call sendRequest() and returns a Promise.

davidfrtala avatar May 28 '18 10:05 davidfrtala

@davidfrtala Not yet, thanks for tellling me! Will update it when I have time.

adityapurwa avatar May 28 '18 15:05 adityapurwa

Thanks for the PR @adityapurwa. This looks good to me, but I honestly don't have a lot of experience with TypeScript so I'm probably not the best person to comment on it.

But this doesn't conflict with anything, so if you give me a 👍 I'll merge this in.

Charca avatar May 29 '18 01:05 Charca