PinView icon indicating copy to clipboard operation
PinView copied to clipboard

[Change Request] Prefix the attrs values.

Open leobrujah opened this issue 4 years ago • 3 comments

Description:

Would be possible to prefix the attrs values in order to not conflict with other libraries?

At the moment, the attribute attr/viewType conflicts with one with the same name in the new Androidx Media2 library androidx.media2:media2-widget. Prefixing to something like pin_viewType pin_backgroundColor would almost 100% prevent conflict issues of attributes.

leobrujah avatar Aug 08 '19 10:08 leobrujah

same issue here

PembaTamang avatar Jul 23 '20 12:07 PembaTamang

jetified-pinview-1.4.3/res/values/values.xml:14:5-32:25: AAPT: error: duplicate value for resource 'attr/viewType' with config ''.

still there

quensh93 avatar Oct 27 '20 05:10 quensh93

This commit exists on "develop" branch and must be added (cherrypick) to "master" branch as well

jemshit avatar Jan 28 '21 16:01 jemshit