shopify-sdk icon indicating copy to clipboard operation
shopify-sdk copied to clipboard

remove deprecated fields, change customerid to long from string

Open jconnolly opened this issue 2 years ago • 5 comments

see here: https://shopify.dev/changelog/property-deprecations-in-the-rest-admin-api-order-resource

jconnolly avatar Feb 05 '22 12:02 jconnolly

@jconnolly can you also just make sure you pull the changes from develop, that have the github actions configurations in it. We can't merge anything until those build checks pass.

ryankazokas avatar Feb 06 '22 21:02 ryankazokas

For sure. I actually didn't see the contribution guidelines and the fact that this uses git-flow until after I already started working on my fork. I'll update accordingly.

jconnolly avatar Feb 07 '22 16:02 jconnolly

For sure. I actually didn't see the contribution guidelines and the fact that this uses git-flow until after I already started working on my fork. I'll update accordingly.

This branch/fork should have everything from develop already. I can see the github actions in my history.

jconnolly avatar Feb 07 '22 16:02 jconnolly

This branch/fork should have everything from develop already. I can see the github actions in my history.

Ah okay thanks!, then it's probably because of the naming convention of the branch we are targeting in the pipelines file. I think we can specifically target PR's, so i'll make that change shortly so you can pull and the actions will run here.

ryankazokas avatar Feb 09 '22 01:02 ryankazokas

@jconnolly can you try pulling again from develop? I've added PR's to the list of actions to run those for.

ryankazokas avatar Mar 02 '22 00:03 ryankazokas