shopify-sdk icon indicating copy to clipboard operation
shopify-sdk copied to clipboard

Feature/fix missing properties

Open WyekS opened this issue 3 years ago • 4 comments

Title

Adding and creating new fields to get Orders, Products and Customer properly

Description of Changes

This models have been created:

  • AbstractModel (to implement admin_graphql_api_id field in some models)
  • model/discount/
    • DiscountAllocation
    • DiscountApplication
    • DiscountCode
  • model/price/
    • Money
    • PriceSet
  • Duty
  • PaymentDetails
  • Property
  • SMSMarketingConsent

This models have been change with new necessary attributes

  • Image
  • ShopifyAddress
  • ShopifyCustomer
  • ShopifyFulfillment
  • ShopifyLineItem
  • ShopifyOrder
  • ShopifyProduct
  • ShopifyShippingLine
  • ShopifyTaxLine
  • ShopifyVariant

After this changes Orders, Products and Customer have been obtained correctly In Shop model has been ignored the new attributes for the moment

Possible Drawbacks

Without these changes the SDK did not work when getting the shop and when you wanted to get orders, products or customers. Now it's possible.

WyekS avatar Oct 29 '21 11:10 WyekS

Any plans for review of this PR? These changes are very important!

dimaloop avatar Feb 01 '22 13:02 dimaloop

Thanks for the PR! Can you switch your PR target to be the develop branch? Also update it with the base so that github actions run.

Without these changes the SDK did not work when getting the shop and when you wanted to get orders, products or customers. Now it's possible.

What errors are you seeing? We recently made changes to the SDK to include API version. This API has been tested with version 2021-07.

ryankazokas avatar Feb 01 '22 16:02 ryankazokas

Hi! I made those changes in Octuber '21. So, I think you probably fixed all things in hotfix 2.4.3 (December '21), but I need a few days to review that new version and if you need some of my changes, I can implement them in the current development branch if you think it's ok :slightly_smiling_face:

WyekS avatar Feb 02 '22 08:02 WyekS

Sounds good. Some things have changed since then, including we moved to Github actions. So if you want to keep this PR open and use this if you see any changes that need to be made, just make sure you switch target to develop and pull the changes, otherwise we won't be able to merge the PR unless all of the checks pass.

ryankazokas avatar Feb 02 '22 14:02 ryankazokas