PvPManager icon indicating copy to clipboard operation
PvPManager copied to clipboard

Block opening plugin menus

Open zLunarKnight opened this issue 1 year ago • 7 comments

Hello, I want to inform you that it does not block all the commands, specifically the menus, for example the /buy of buycraft does not block it although you can use it in combat and there is a blockhit bug when you use /buy in pvp, not specifically in pvp but it can be bugged and other menus that don't block are the deluxemenus ones, surely there are more, I just don't know about it, if they solve it it would be better!

zLunarKnight avatar Apr 02 '24 21:04 zLunarKnight

Hello, can you show your current config, you can send the entire config or just the part that blocks commands if you want. Then I'll test it and try to fix it if needed. I do think /buy gets blocked with no problem but I will retest it just in case.

ChanceSD avatar Apr 03 '24 02:04 ChanceSD

Alright, so I tested it with BuycraftX and it's not possible to block the /buy command because of how badly coded that plugin is. They just made it in a way that it can't be blocked...

However, if you update to the new Tebex plugin they made https://www.spigotmc.org/resources/tebex.114261/ it seems to block it fine on that one.

Not sure about DeluxeMenus yet though, still need to test that one. Would be nice if you can give me some example menu to test.

ChanceSD avatar Apr 03 '24 04:04 ChanceSD

Okay, here is a warp menu

https://mclo.gs/M8b9g0z

zLunarKnight avatar Apr 03 '24 21:04 zLunarKnight

The /buy command may be blocked when the player executes the command in combat and instantly closes the menu or any menu closes when used in combat.

zLunarKnight avatar Apr 03 '24 21:04 zLunarKnight

Oh I guess I can just block inventories from opening instead of only blocking the commands sure, will probably add an option for that then.

ChanceSD avatar Apr 03 '24 21:04 ChanceSD

Try this build please, it should block opening menus while in combat: https://ci.codemc.io/job/ChanceSD/job/PvPManager/317/

ChanceSD avatar Apr 06 '24 18:04 ChanceSD

@zLunarKnight Just in case you didn't see, sorry if you already did.

ChanceSD avatar Apr 07 '24 16:04 ChanceSD

Well I'm gonna assume this is solved.

ChanceSD avatar Apr 17 '24 05:04 ChanceSD