ChanceNCounter
ChanceNCounter
Looks like some of the English and Slovenian res files got nuked when you renamed that file (hello, fellow regex person! 😁)
Now having more time to review, I'm not sure `pluralizations` is a better name, because it now also houses the singlar forms of critical vocabulary. Perhaps something like `common_words.json` or...
@JarbasAl bump re: compatibility with variants, possible need for integration (plural variants?)
Partially misplaced, I think. Apparently planned #150 `format.pronounce_digits()` would be a more appropriate function call for the suggested behavior. However, I'm not sure if it retains leading zeroes at the...
I stand corrected. In the current version of the PR, `format.pronounce_digits()` does indeed preserve leading zeroes: ``` >>> format.pronounce_digits("014606") 'zero one four six zero six'
On reflection, the "fail" case above is OOS. If the input appears to mean something specific - `"46" == 46.0` - LF can't account for whether the program calling its...
`anchorDate` becomes a little tricker still in that it's probably passed positionally in a lot of places. Deprecation works the same way it ever would, but it's mildly cruel, in...
Review changes: Irrelevant funcs removed. Default TZ set to UTC.
Having lost the (internal) single source of truth, I'd just as happily clobber naive DTs to the system TZ. The problem arises in the broader ecosystem. The original reason I...
I think we should keep in mind that, even if this library is never used outside the Mycroft community, skill developers will inevitably want to parse numeric information for pronunciation....