Chameleon icon indicating copy to clipboard operation
Chameleon copied to clipboard

Decouple managers from platform's Chameleon

Open LooFifteen opened this issue 2 years ago • 2 comments

Confirmation

  • [X] I have checked for similar issues.

Problem

Currently, when creating support for a Bukkit-based platform, BukkitChameleon must be extended to grant access to Bukkit's manager classes. If these managers begin to use the abstracted classes rather than the internals where possible, it'll be less hacky when adding a platform like this to Chameleon.

Suggested solution

Prefer abstract classes over internal implementation in managers.

Additional information

No response

LooFifteen avatar Mar 30 '23 19:03 LooFifteen

This is solved, right?

LooFifteen avatar Sep 14 '23 11:09 LooFifteen

This is solved, right?

The Bukkit managers have been decoupled. I meant to ask whether you also wanted other platforms decoupled (which I don't really see much of a reason to do this, right?).

joshuasing avatar Sep 14 '23 12:09 joshuasing