WalletConnectUnity integration
WIP
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: creeppak
:white_check_mark: rob1997
:x: =
= seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
It is planned to be released with 2.6.1
Fixed branch last week. Juan is testing the success rate for the connection of different wallets.
Fixed branch last week. Juan is testing the success rate for the connection of different wallets.
On it! In the mean time you can fix the recent merge conflicts that appear
@oleksandrchainsafe I did some connections with the wallets that Wallet connect support, here is the report:
-
Metamask ❌
-
Trust wallet ✅
-
Binance Web3 wallet ✅
-
Uniswap ❌
-
Zerion ❌
-
SafePal ✅
-
Rainbow ❌
-
Ledger Live ✅
-
Coinbase Wallet ❔ (I couldn't connect coinbase wallet at all, but doesnt looks like our issue)
I dont count Coinbase Wallet, so we can connect to 4 wallets out of 8. Success rate is 0.5
@juans-chainsafe and what about the regular WC that is in 2.6?
@juans-chainsafe and what about the regular WC that is in 2.6?
Metamask ✅ Trust wallet ❌ Binance Web3 wallet ❌ Uniswap ❌ Zerion ❌ SafePal ✅ Rainbow ❌ Ledger Live ✅
3/8 So, the new implementation has 4/8, only 1 more, but doesnt connect with Metamask, which is the most important one
@juans-chainsafe and what about the regular WC that is in 2.6?
Metamask ✅ Trust wallet ❌ Binance Web3 wallet ❌ Uniswap ❌ Zerion ❌ SafePal ✅ Rainbow ❌ Ledger Live ✅
3/8 So, the new implementation has 4/8, only 1 more, but doesnt connect with Metamask, which is the most important one
I also want to add, that with this integration, takes more time to load the Wallet connect screen with the QR code, way more than before.
It was decided we won't use this version for now, as it performs purely as described by Juan in previous messages. We are, however, going to keep this in the repo but disable it, so it's not accessible to the user.
Closing PR but keeping the branch as a reference point. Might be useful if we decide to integrate it again some time in the future.