web3.unity icon indicating copy to clipboard operation
web3.unity copied to clipboard

Remove CSServer and old scripts that are using it

Open juans-chainsafe opened this issue 1 year ago • 0 comments

Summary The endpoints that we are using in CSServer will be deprecated, so we need to remove them from the code. The good thing is that we are not using any of the scripts in the SampleMain samples, so should we risk free.

Suggested features or ways to address the summary Endpoints that will be removed:

  • /evm/collection/check
  • /evm/collection/create
  • /evm/collection/get
  • /evm/collection/getAll
  • /evm/collection/getByNft
  • /evm/collection/update
  • /evm/collection/remove
  • /evm/collection/addNFTsFromCollection
  • /evm/createApproveTransaction
  • /evm/createCancelNftTransaction
  • /evm/createMintNFTTransaction
  • /evm/createRedeemTransaction
  • /evm/createListNftTransaction
  • /evm/createPurchaseNftTransaction
  • /evm/getListedNfts
  • /evm/getMarketplaceData
  • /evm/getMintedNfts
  • /evm/getNftData
  • /evm/reportContent

I found these endpoints being used in:

  • CSSServer.cs
  • CreateApproval.cs
  • GetListedCollections.cs
  • GetListedNFT.cs
  • ListCollections.cs
  • ListNft.cs

Motivation We shouldn't have code that can't be used

Acceptance Criteria

  • None of the endpoints mentioned before should be in web3.unity, neither the scripts that were using them

Blockers

  • We may have old game projects with an old SDK version that are using something of the NFT stuff but unlikely and not sure how to check since we don't have Datadog anymore

juans-chainsafe avatar Mar 19 '24 12:03 juans-chainsafe