web3.unity icon indicating copy to clipboard operation
web3.unity copied to clipboard

Converting Pointer_stringify calls to UTF8ToString in .jslib

Open longda opened this issue 2 years ago • 5 comments

Just updated the .jslib file from Pointer_stringify to UTF8ToString

Not sure if this breaks backwards compatibility. Here's a link I found in the Unity documents:

No deep link... search for "WebGL: Updated Emscripten to 2.0.19" https://docs.unity3d.com/2021.2/Documentation/Manual/UpgradeGuide20212.html

This resolves issue 208.

longda avatar Aug 09 '22 22:08 longda

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '22 22:08 CLAassistant

@KBryan this look good to me, did you see any issues for oldest Unity version?

LuaxY avatar Aug 22 '22 15:08 LuaxY

this has some issues regarding some of our live marketplace features, this will need testing.

sneakzttv avatar Aug 22 '22 15:08 sneakzttv

Thank you for this submission. As @sneakzttv mentioned this had adverse effects when we implemented it a while back. Although, we can revisit this and possibly make the necessary changes within the logic found in the SDK.

KBryan avatar Aug 26 '22 21:08 KBryan

yah, marketplace prefabs flip out, not a hard fix, will look monday.

sneakzttv avatar Aug 26 '22 21:08 sneakzttv

complete in v2

sneakzttv avatar Jan 17 '23 13:01 sneakzttv