lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

fix: upgrade version of parcel/watcher that resolves

Open matthewkeil opened this issue 1 month ago • 1 comments

Motivation

Issue upgrading to Node 24. Docker build on macos fails. Upgrades dependency

matthewkeil avatar Dec 09 '25 19:12 matthewkeil

Summary of Changes

Hello @matthewkeil, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build failure that occurred during the upgrade to Node.js 24, specifically impacting Docker builds on macOS. The core solution involves forcing an update of the @parcel/watcher dependency to a compatible version, thereby stabilizing the build process and ensuring continued development without environment-specific hindrances.

Highlights

  • Dependency Upgrade: The @parcel/watcher dependency has been explicitly upgraded to version 2.5.1 using a resolution in package.json.
  • Node.js 24 Compatibility: This upgrade resolves an issue preventing successful Docker builds on macOS when using Node.js 24.
  • Lockfile Updates: The yarn.lock file has been updated to reflect the new @parcel/watcher version, including its platform-specific optional dependencies and an updated node-addon-api version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 09 '25 19:12 gemini-code-assist[bot]

Do we still need this after #8675 ?

philknows avatar Dec 10 '25 14:12 philknows

Do we still need this after #8675 ?

no

nflaig avatar Dec 10 '25 14:12 nflaig

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 52.04%. Comparing base (688d558) to head (9c6bdec). :warning: Report is 1 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #8676   +/-   ##
=========================================
  Coverage     52.04%   52.04%           
=========================================
  Files           848      848           
  Lines         65734    65734           
  Branches       4807     4807           
=========================================
  Hits          34214    34214           
  Misses        31451    31451           
  Partials         69       69           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 14:12 codecov[bot]