lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

feat: pass `skipRandaoVerification` to `processRandao` correctly

Open mkermani144 opened this issue 7 months ago • 1 comments

Motivation

Allow the block production API to skip RANDAO verification of the block.

Description

While skipping RANDAO verification was already implemented, it was not actually used. In other words, the block production endpoint accept such query param, but it didn't pass it to processRandao (the function that verifies RANDAO) correctly.

Fix the issue by passing the skipRandaoVerification to processRandao via some intermediate functions that are called in the process.

Closes #4638

mkermani144 avatar May 24 '25 11:05 mkermani144

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.81%. Comparing base (99033e3) to head (faf6326). Report is 65 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #7870      +/-   ##
============================================
- Coverage     55.81%   55.81%   -0.01%     
============================================
  Files           823      823              
  Lines         58157    58178      +21     
  Branches       4496     4499       +3     
============================================
+ Hits          32463    32474      +11     
- Misses        25627    25637      +10     
  Partials         67       67              
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 25 '25 19:05 codecov[bot]

Thanks @mkermani144 for taking a look at this but as noted in https://github.com/ChainSafe/lodestar/issues/4638#issuecomment-3090543719 I don't feel like it makes sense to implement this right now.

I think we should close this

nflaig avatar Jul 18 '25 19:07 nflaig

Closing due to previous comment.

mkermani144 avatar Jul 19 '25 08:07 mkermani144