ChainSafe
Add lodestar prefix to validator monitor metrics
Problem description
Validator monitor metrics validator_monitor_ should be also prefixed with lodestar_:
lodestar_validator_monitor_ instead of validator_monitor_. Potentially it should be fixed in 2.0 release.
Originally posted by @nflaig in #7722 (comment)
Solution description
Add lodestar_ prefix for all validator_monitor_ metrics.
Additional context
No response
Is it a breaking change for Validator Monitor dashboard users? It will affect a lot of metrics. Or 2.0 release is a breaking change itself?
Is it a breaking change for Validator Monitor dashboard users? It will affect a lot of metrics. Or 2.0 release is a breaking change itself?
technically changing metric names is a breaking change as metrics are an external api but depending on which metric it is and how long it has been around in lodestar we can make exceptions
for this specific case, I think we need to be careful, I would rather do it in our 2.0 release and note it clearly in breaking changes
also would be curious if anyone knows why we didn't use prefix here, I know that Lion implemented it based on what Lighthouse had and the even have a dashboard for it ValidatorMonitor.json which uses the same metric names, so maybe the idea was to have them standardized.
I imported that dashboard on my node but it doesn't seem to work pretty well with lodestar
some panels work though
I guess we should consider if it's even worth renaming the metrics, those have been around for a long time like this
I will note that currently #7011 is still technically in scoping and no decision has been made yet on a catalyst feature/upgrade for setting some sort of estimate to its potential release. Was one of the discussions I plan to have in more detail for consensus with the team in June. Noting this as part of something we can target with 2.0
Noting this as part of something we can target with 2.0
yes we can keep track of this there, metrics renaming, cli flag renaming, etc. should only be done in a major release