lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Make `MAX_REQUEST_BLOB_SIDECARS` and `MAX_BLOBS_PER_BLOCK` configurable

Open ensi321 opened this issue 1 year ago • 0 comments

Problem description

In ethereum/consensus-specs#3817, MAX_BLOBS_PER_BLOCK is moved from preset to config.

This poses a challenge in Lodestar since BlobSidecarsByRootRequest - a fixed length ssz container depends on it but types package has no access to chain.config.

Solution description

I believe this is the only place in the spec has a ssz container for which its definition relies on a variable from config.

We can either make a one time exception and define BlobSidecarsByRootRequest ssz in beacon-node or further refactor to be more future proof if such scenario happens again.

cc. @g11tech

Additional context

No response

ensi321 avatar Oct 17 '24 03:10 ensi321