lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

feat: added release page in docs

Open jeluard opened this issue 10 months ago • 9 comments

Motivation

Display releases in the documentation

This is a first draft aiming at initiating discussion to figure out what is the best option to share releases.

Capture d’écran 2024-04-14 à 22 23 56

I can see 2 angles:

  • list all binaries per release (above screenshot)
  • list binaries per platform (same as geth)

jeluard avatar Apr 14 '24 21:04 jeluard

Codecov Report

Merging #6669 (4e58e65) into unstable (2d766ca) will increase coverage by 0.13%. Report is 4 commits behind head on unstable. The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #6669      +/-   ##
============================================
+ Coverage     61.67%   61.81%   +0.13%     
============================================
  Files           556      556              
  Lines         58834    59050     +216     
  Branches       1888     1898      +10     
============================================
+ Hits          36288    36502     +214     
  Misses        22505    22505              
- Partials         41       43       +2     

codecov[bot] avatar Apr 14 '24 21:04 codecov[bot]

Since we're starting with just linux x86_64 and arm64 binaries, I think its fine to just group them together like you have now. We don't need to list the .node files since they are not useful for user download (maybe you just have them there as an example)

wemeetagain avatar Apr 17 '24 14:04 wemeetagain

@wemeetagain Right, I'm using blst repo for those tests which publishes those node files as part of releases.

jeluard avatar Apr 17 '24 23:04 jeluard

I tend to agree with @nflaig here. Binaries are just another installation method and should just have its own section under Installation.

I do like the way you cleanly table the releases here, but we definitely don't need to list all of them. I would maybe only go 5 releases back at most, similar to what we would be doing with docs versions. There should be no reason why (nor should we promote) having people stay more than 5 releases behind. This is a pretty weak assumption on my part and open to other opinions.

philknows avatar Apr 27 '24 14:04 philknows

should just have its own section under Installation.

What about having a separate page per installation method? We had this previously (before https://github.com/ChainSafe/lodestar/pull/6134), this makes it easier to read and less overloaded with instructions that are unrelated to each other.

nflaig avatar Apr 27 '24 15:04 nflaig

That is also an option so we can keep various installation methods and their quirks separate from each other. So perhaps:

  • Getting Started
    • Quick Start
    • Installation via Binaries
    • Installation via Docker
    • Installation via NPM (which will literally say don't do this for production - instructions were removed to deter this)
    • Starting a Node (which I would recommend in another PR to move into the "Beacon Node" H1 dropdown.

philknows avatar Apr 27 '24 15:04 philknows

So perhaps:

or subsections in installation

Starting a Node (which I would recommend in another PR to move into the "Beacon Node" H1 dropdown.

Maybe we need to rethink what should be part of getting started, just having installation in there is also a bit strange

nflaig avatar Apr 27 '24 15:04 nflaig

It probably makes sense to reconsider this in the context of https://github.com/ChainSafe/lodestar/issues/6550

jeluard avatar Apr 29 '24 05:04 jeluard

Noticed Lighthouse has same layout for Installation as I had in mind

image

This would also allow to use the page you created in this PR I would assume

nflaig avatar May 03 '24 11:05 nflaig

Noticed Lighthouse has same layout for Installation as I had in mind

image

This would also allow to use the page you created in this PR I would assume

is this a possible layout we can go for right now? This feels important to have on the next release, otherwise we will have really low visibilty on the binaries as an installation option (other than announcing it in release notes)

nflaig avatar Jun 03 '24 21:06 nflaig

is this a possible layout we can go for right now? This feels important to have on the next release, otherwise we will have really low visibilty on the binaries as an installation option (other than announcing it in release notes)

I would say as a stop-gap measure, we can at least get the layout for Installation section as described here so we can include some instructions for the binaries? This might be better off as another PR though @jeluard. We haven't come to a conclusion about this release page in the docs, but every layout discussed in #6550 doesn't include this page. So we can close this one off unless someone expresses desire to include this by standup discussion tomorrow on #6829

philknows avatar Jun 03 '24 21:06 philknows

Would make sense to bundle this page with the new docs layout, one less broken link to deal with. Feels like we are close to be able to make a decision on #6550 , would be cool to make a call on it.

jeluard avatar Jun 04 '24 08:06 jeluard

It's been decided to rely on GitHub releases page for now instead.

jeluard avatar Jun 06 '24 15:06 jeluard

It's been decided to rely on GitHub releases page for now instead.

Are we still gonna highlight binaries as an installation method in the docs? We can just ref to release on github for users to find the download link

nflaig avatar Jun 06 '24 15:06 nflaig

@nflaig Yes, you can see how it's done in the related PR about documentation layout updates.

jeluard avatar Jun 06 '24 15:06 jeluard

Yeah I'm fine with how it is now, but I understand you wanted it as a higher level heading on its own page based on the LH docs structure. I'm indifferent. As long as it's in the docs, that's what is most important for now IMO.

philknows avatar Jun 06 '24 16:06 philknows