lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Add block_gossip SSE event

Open nflaig opened this issue 1 year ago • 3 comments

https://github.com/ethereum/beacon-APIs/pull/405

nflaig avatar Feb 22 '24 11:02 nflaig

Is this issue still open, can you assign it to me.

Ayoseun avatar Mar 04 '24 14:03 Ayoseun

Thanks for reaching out on Discord @Ayoseun!!!

The block passes validation in validateGossipBlock and is handled in handleValidBeaconBlock. Please read through the discussions about the SSE event (not an inclusive list) and make sure you understand the edge cases if there are any for this event.

  • https://github.com/ethereum/beacon-APIs/pull/405
  • https://github.com/ethereum/beacon-APIs/pull/404
  • https://github.com/ethereum/beacon-APIs/issues/349

After briefly reading about the event, it feels like the entrance to the feature will be in handleValidBeaconBlock but will leave the implementation details up to your discretion.

Thanks for the help and feel free to message us on discord if you have any other questions.

matthewkeil avatar May 29 '24 08:05 matthewkeil

Thanks for this, i have gone through the discussion.

Ayoseun avatar May 31 '24 09:05 Ayoseun