lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Support all network configs

Open nflaig opened this issue 1 year ago • 0 comments

After reviewing the spec values I noticed we are still missing plenty of network values which should be part of the config (configs/mainnet.yaml#L113-L150). We either don't support them or those are defined as constants.

I looked into refactoring this to move all of the constants into config but not all parts of the code that use those values can get access to configs easily, for example values used in rateLimitQuotas https://github.com/ChainSafe/lodestar/blob/2db7120f3534faf5c023954f4065912dd0c2691f/packages/beacon-node/src/network/reqresp/rateLimit.ts#L11 While it should be possible to refactor the code to make this work, I think we should avoid large changes before the Deneb hard fork as current configuration is well tested already and there is no specific requirements to move those values from constants to config.

From https://github.com/ChainSafe/lodestar/pull/6328

nflaig avatar Jan 24 '24 09:01 nflaig