lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

feat: add endpoint for sync committee reward

Open ensi321 opened this issue 2 years ago • 1 comments

Description introduce a beacon API endpoint to return sync committee reward info according to the spec. This is one of the three reward endpoints mentioned in https://github.com/ChainSafe/lodestar/issues/5694

Note that the endpoint currently only supports Altair block or later. Attempts to query for phase0 block will return error.

ensi321 avatar Jan 08 '24 14:01 ensi321

Codecov Report

Merging #6260 (0fde64e) into unstable (8943ab6) will increase coverage by 0.03%. Report is 10 commits behind head on unstable. The diff coverage is 97.91%.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #6260      +/-   ##
============================================
+ Coverage     61.72%   61.75%   +0.03%     
============================================
  Files           555      555              
  Lines         58204    58253      +49     
  Branches       1839     1846       +7     
============================================
+ Hits          35925    35975      +50     
+ Misses        22240    22238       -2     
- Partials         39       40       +1     

codecov[bot] avatar Jan 08 '24 15:01 codecov[bot]

Would it make sense to check if this ignored test now pass?

jeluard avatar Mar 01 '24 10:03 jeluard

Would it make sense to check if this ignored test now pass?

They are passing, see https://github.com/ChainSafe/lodestar/actions/runs/8106861427/job/22157579712?pr=6260#step:5:480

But we might wanna consider increasing verbosity of test output, not seeing which tests cases are executed and just the file name is not ideal. But test/unit/beacon/genericServerTest/beacon.test.ts has 33 tests on unstable branch and 34 here, so we know it was removed correctly from the ignore list.

nflaig avatar Mar 01 '24 11:03 nflaig

They are passing, see https://github.com/ChainSafe/lodestar/actions/runs/8106861427/job/22157579712?pr=6260#step:5:480

Ah right, I missed the changes in oapiSpec. Looks good.

jeluard avatar Mar 01 '24 11:03 jeluard

:tada: This PR is included in v1.17.0 :tada:

wemeetagain avatar Mar 11 '24 15:03 wemeetagain