lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Lint and fix unused expressions

Open nflaig opened this issue 2 years ago • 1 comments

Need track of unused expressions to clean up the code and avoid potential bugs.

For example this was missed due to missing lint rule. The assertion error has never been added to the list of errors.

https://github.com/ChainSafe/lodestar/blob/c780a1d450b4def5b1c167f72507881dd9c10eb6/packages/cli/test/utils/simulation/assertions/defaults/missedBlocksAssertion.ts#L36-L42

Could also consider adding other linters/scanners to CI such as SonarQube.

As discussed in discord

nflaig avatar May 17 '23 18:05 nflaig

  • related to #6011

philknows avatar Nov 07 '23 19:11 philknows