lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Gossip block signatures verification on main thread

Open twoeths opened this issue 2 years ago • 2 comments

Describe the bug

Right now we verify gossip block proposer's signature on main thread but all other signatures on worker thread

Expected behavior

  • Need to understand if it's better to also verify all gossip block's signatures on main thread because the faster we process the gossip block the better
  • Add metric to track the time for it

twoeths avatar Apr 25 '23 06:04 twoeths

with v1.8.0-rc.0 the time to verify execution payload is bigger so it may not be a priority atm

  • block slot 6314643
581396:Apr-27 12:49:00.129[network]       verbose: Received gossip block slot=6314643, root=0x9ddc…0070, curentSlot=6314643, peerId=16Uiu2HAm3R979jPjTqW5Vdt16H7x6Kn6j91BsmvGL2C5CSDQyfo4, delaySec=1.1129999160766602, recvToVal=0.016000032424926758
581397:Apr-27 12:49:00.206[chain]         verbose: Transitioned gossip block slot=6314643, recvToTransition=0.09300017356872559
581398:Apr-27 12:49:00.235[chain]         verbose: Verified block signatures slot=6314643, recvToSigVer=0.12199997901916504
581399:Apr-27 12:49:00.337[chain]         verbose: Verified execution payload slot=6314643, recvToVerifiedExecPayload=0.2239999771118164
581405:Apr-27 12:49:00.891[chain]         verbose: Imported block slot=6314643, recvToImportedBlock=0.7780001163482666
  • block slot 6314644
581623:Apr-27 12:49:12.138[network]       verbose: Received gossip block slot=6314644, root=0x92b3…b540, curentSlot=6314644, peerId=16Uiu2HAm3R979jPjTqW5Vdt16H7x6Kn6j91BsmvGL2C5CSDQyfo4, delaySec=1.1170001029968262, recvToVal=0.020999908447265625
581624:Apr-27 12:49:12.238[chain]         verbose: Transitioned gossip block slot=6314644, recvToTransition=0.12099981307983398
581625:Apr-27 12:49:12.284[chain]         verbose: Verified block signatures slot=6314644, recvToSigVer=0.16699981689453125
581626:Apr-27 12:49:12.428[chain]         verbose: Verified execution payload slot=6314644, recvToVerifiedExecPayload=0.31099987030029297
slot recvToVal recvToTransition recvToSigVer recvToVerifiedExecPayload
6314643 0.016 0.093 0.1219 0.2239
6314644 0.02099 0.12099 0.16699 0.31099
6314645 0.045 0.1319 0.158 0.305
6314646 0.0169 0.0959 0.1229 2.14

twoeths avatar Apr 27 '23 23:04 twoeths

@twoeths can this be closed?

wemeetagain avatar Oct 15 '24 16:10 wemeetagain