lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Prevent circular dependencies with eslint

Open dapplion opened this issue 2 years ago • 3 comments

Motivation

'import/no-cycle' is expensive computationally, consider restricting its maxdepth

See https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-cycle.md#maxdepth

A lint run in master currently takes Done in 121.30s. in Github Actions (from https://github.com/ChainSafe/lodestar/runs/5137987474?check_suite_focus=true#step:13:38)

In this PR for a failed run it took in 137.5s so the extra time is okay :+1:

Description

Prevent circular dependencies with eslint

See https://github.com/ChainSafe/lodestar/pull/3742 for an example implementation

dapplion avatar Apr 16 '22 12:04 dapplion

Related to #6011

philknows avatar Nov 05 '23 15:11 philknows