gossamer icon indicating copy to clipboard operation
gossamer copied to clipboard

Validate radiumblock bootnode multihash against go-multihash implementation

Open q9f opened this issue 2 years ago • 2 comments

          > I took it from the upstream PR here: [paseo-network/runtimes#12](https://github.com/paseo-network/runtimes/pull/12)

How can I double check the issue is upstream and not our implementation?

We use https://github.com/multiformats/go-multiaddr to parse these p2p addresses, so I think we should investigate its implementation, the parse is done at dot/network/utils.go in the function stringToAddrInfo

Originally posted by @EclesioMeloJunior in https://github.com/ChainSafe/gossamer/issues/3703#issuecomment-1898976058

q9f avatar Jan 18 '24 20:01 q9f

Just posting this here for myself as a homework.

q9f avatar Jan 18 '24 20:01 q9f

Based on this spec

I think the right addrs should be:

"/dns/paseo-bootnode.radiumblock.com/tcp/30333/p2p/12D3KooWADeayZC8zag4Qrb4GosSn65MmfVZztRPMaBdgZnQqXRo"
"/dns/paseo-bootnode.radiumblock.com/tcp/30335/wss/p2p/12D3KooWADeayZC8zag4Qrb4GosSn65MmfVZztRPMaBdgZnQqXRo"

I tested them and they passed the test

dimartiro avatar Feb 02 '24 22:02 dimartiro