forest
forest copied to clipboard
ChainSafe
🌲 Rust Filecoin Node Implementation
does it need to be cloned? _Originally posted by @LesnyRumcajs in https://github.com/ChainSafe/forest/pull/3689#discussion_r1386547233_
Forest wants to use Lotus' OpenRPC definitions to ensure RPC compatibility. But we've found that most endpoints are incorrect. Here are some examples: Snippets are taken from [Lotus' OpenRPC definitions](https://github.com/filecoin-project/lotus/blob/v1.23.3/build/openrpc/full.json.gz),...
https://github.com/ChainSafe/forest/actions/runs/6734221792/job/18304630910 https://github.com/ChainSafe/forest/actions/runs/6546848863/job/17778151044 https://github.com/ChainSafe/forest/actions/runs/6587472405/job/17897823529 Call to `cargo check` fails, no diags :/
**Issue summary** Currently, we have manual `libp2p::NetworkBehaviour` implementations for `HelloBehaviour`, `ChainExchangeBehaviour`, and `DiscoveryBehaviour`, for better readability, we could - [ ] Evaluate and refactor `impl NetworkBehaviour for HelloBehaviour` into async...
https://github.com/ChainSafe/forest/blob/f04adb8eae13c96b5750b875c6dd8c9543351773/src/db/car/any.rs#L22-L26 The `AnyCar` has a type hole on the third discriminant, and the `into_dyn` methods everywhere are a serious code smell.
**Issue summary** Sending FIL tokens using the `send` command while a Forest DB garbage collection is running will result in a failed transaction, and no message will be included in...
| Link | Works | | - | - | | https://forest-archive.chainsafe.dev/latest/calibnet/ | ✅ | | https://forest-archive.chainsafe.dev/latest/calibnet | ❌ | | https://forest-archive.chainsafe.dev/list/ | ✅ | | https://forest-archive.chainsafe.dev/list | ❌ |...
# The current state - Types are defined here, using a naming scheme: https://github.com/ChainSafe/forest/blob/d6c96279addda1aea800654d9c12b9f8b2ce08ee/src/rpc_api/mod.rs#L192-L206 - Logic is defined in a separate file: https://github.com/ChainSafe/forest/blob/b3057ba599d285b5306c9c636ef08facb1f2ea42/src/rpc/chain_api.rs#L25-L39 I'd think we need a [`tower`](https://docs.rs/tower/latest/tower/)-compatible API:...
- #3297 noted that our JSON approach was confusing - #3339 introduced some standardisation with a `HasLotusJson` trait, and clarified the issues with the prior approach - #3345 introduced the...