run shellcheck against `.github/workflows/*.yml`

Open hanabi1224 opened this issue 1 year ago • 1 comments

          It might make sense to put those in files. It would somehow unclutter the yaml files (less important), but it will allow `shellcheck` linting, which will enforce good practices. They can even live in `.github/`. What do you think?

Originally posted by @LesnyRumcajs in https://github.com/ChainSafe/forest/pull/4086#discussion_r1535496734

Mar 25 '24 03:03 hanabi1224

Note that more complicated scripts should still be moved to separate files to unclutter the workflows; see it as refactoring code to smaller functions so that it's on a similar level of abstraction.

Mar 25 '24 12:03 LesnyRumcajs