forest Avoid all uses of async-std except when spawning tasks

Avoid all uses of async-std except when spawning tasks

Open lemmih opened this issue 1 year ago • 4 comments

Reference issue to close (if applicable)

Closes #1947

Other information and links

Sep 22 '22 12:09 lemmih

Unresolved question: What to do about tide? It requires async_std. Can we use a different crate for the RPC server?

Sep 22 '22 13:09 lemmih

Unresolved question: What to do about tide? It requires async_std. Can we use a different crate for the RPC server?

There was an issue to potentially replace tide, I'd look into either warp or rocket.

edit: the issue https://github.com/ChainSafe/forest/issues/1761

Sep 22 '22 13:09 LesnyRumcajs

Or maybe actix. The jsonrpc-v2 library has support for that crate but maybe that doesn't mean much.

Sep 22 '22 13:09 lemmih

actix was a bit rough the last time I used it; the API wasn't as high-level as it could be. Perhaps something changed though.

Sep 22 '22 14:09 LesnyRumcajs

Nice! Could you update the branch with the new toolchain? (will be easier to switch branches).

Sep 30 '22 09:09 elmattic

Nice! Could you update the branch with the new toolchain? (will be easier to switch branches).

Done.

Sep 30 '22 12:09 lemmih

Did you try moving to tokio::test too? Or maybe we will just port the tests in a separate PR?

~~Same question for using tokio::net::TcpListener.~~ -> related to tide issue mentionned in the PR summary.

Oct 03 '22 12:10 elmattic

Did you try moving to tokio::test too? Or maybe we will just port the tests in a separate PR?

We can switch to tokio::test once we're not using async-std tasks anymore.

Oct 03 '22 12:10 lemmih