forest icon indicating copy to clipboard operation
forest copied to clipboard

FIP 34 - Fix pre-commit deposit independent of sector content

Open lemmih opened this issue 1 year ago • 1 comments

Issue summary

Checklist:

  • [x] Are there any changes to the actor data structures that we need to be aware of?
  • [x] Are there any changes to the network protocol?
  • [x] Are there any changes to node behavior (eg. changes in block validation criteria, random number generation, etc)?
  • [x] Are there any new magic numbers?

Other information and links

https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0034.md

lemmih avatar Sep 13 '22 08:09 lemmih

Data structures change

SectorPreCommitOnChainInfo should be changed to what builtin-actors expose. Same applies to SectorPreCommitInfo. We do some serde tricks so it may not be possible to import it, most likely we'll just need adapt the changes in our implementation.

Logical flow It should be self-contained in builtin-actors.

Related PR: https://github.com/filecoin-project/builtin-actors/pull/484

:warning: Tests :warning: Those structs are used only in our RPC API which is not covered by tests. It would be great to at least test that it works manually.

LesnyRumcajs avatar Sep 21 '22 12:09 LesnyRumcajs