forest icon indicating copy to clipboard operation
forest copied to clipboard

Investigate the test in `peer_test.rs`

Open lemmih opened this issue 1 year ago • 0 comments

Issue summary

We have a module that contains a single test. This module is not used by the crate and the test is therefore not run. We should investigate what to do about this. Possible options:

  • Use the module such that the test is run.
  • Move the test to the tests/ folder. This can only be done if the test doesn't depend on anything private from the crate.
  • Remove the test. Maybe the test isn't relevant anymore and should be removed.

File in question: https://github.com/ChainSafe/forest/blob/main/blockchain/chain_sync/src/sync/peer_test.rs

Other information and links

lemmih avatar Aug 30 '22 11:08 lemmih