CAIPs icon indicating copy to clipboard operation
CAIPs copied to clipboard

Add workflow to check CAIPs

Open ligi opened this issue 2 years ago • 6 comments

#181 needs to be merged first

ligi avatar Nov 20 '22 01:11 ligi

Wouldn't you prefer to use something already built instead of rebuilding a new one?

I've written a re-usable markdown linter for SIPs, which operates on Abstract Syntax Tree of markdown and allows writing custom rules per repository.

For example, this rule checks any external links for 400 statues by visiting specific nodes in AST.

I could release the linter into MIT and publish on NPM and allow it to load CAIPs specific plugins.

Especially since most of CAIPs operate on TypeScript's types and general Web ecosystem assumptions. And while I like Kotlin since I've been writing in it professionally for few years, it's not the language users of this repo will be most familiar with.

ritave avatar Nov 20 '22 23:11 ritave

This is reused - I used it for DIPs before. Link checker there I used another one before - gaurav-nelson/github-action-markdown-link-check@v1 - but actually removed it from this step as Link checking is not deterministic. Feel free to add yours afterwards - this already found stuff and can guard until something else is in place.

ligi avatar Nov 21 '22 00:11 ligi

I'm good with whichever if we're reusing and not writing one anew again.

ritave avatar Nov 21 '22 02:11 ritave

#181 merged. Maybe force-push to see if CI will re-run?

bumblefudge avatar Nov 22 '22 18:11 bumblefudge

@ligi - is this all working?

obstropolos avatar May 04 '23 15:05 obstropolos

@ligi - doing some quick housekeeping - is this all working / some conflicts to resolve.

obstropolos avatar May 23 '24 15:05 obstropolos