brainslug-wii icon indicating copy to clipboard operation
brainslug-wii copied to clipboard

Fix DI return code checks

Open Leseratte10 opened this issue 3 years ago • 2 comments

The old code retried DI_Read calls until the return value was not negative. However, that never happens. DI_Read and most other DI functions have 1 as the success case, and positive numbers larger than 1 for errors. This means that without this PR, reads could sometimes fail (due to disc issues or whatever), and instead of noticing and retrying, Brainslug would just assume that the data was read correctly.

Leseratte10 avatar Feb 06 '21 08:02 Leseratte10