ShineButton icon indicating copy to clipboard operation
ShineButton copied to clipboard

when it used on Android P,the ring was out of position

Open summerhotready opened this issue 5 years ago • 11 comments

snipaste_2019-01-02_08-58-01 on Android P button like this.

summerhotready avatar Jan 02 '19 01:01 summerhotready

I am facing the same issue, did you find out the solution?

RiteshAdulkar avatar Feb 14 '19 08:02 RiteshAdulkar

In my case, this happens when the keyboard is visible: screenrecord_1551263186.mp4.zip

uscheller avatar Feb 27 '19 10:02 uscheller

I am facing the same issue, did you find out the solution?

XD-Z avatar Mar 01 '19 03:03 XD-Z

No, I ended up animating the button myself.

uscheller avatar Mar 01 '19 07:03 uscheller

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone. bottomHeight = metrics.heightPixels - location[1];

ghost avatar Mar 09 '19 17:03 ghost

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone. bottomHeight = metrics.heightPixels - location[1];

how do you fix this problem?

mcxinyu avatar Mar 16 '19 07:03 mcxinyu

I think I know why.because no consideration was given to the bottom navigation bar,but shineView showAnimation method isTranslucentNavigation(shineButton.activity)

if (isTranslucentNavigation(shineButton.activity)) { if (isFullScreen(shineButton.activity)) { centerAnimY = visibleFrame.height() - shineButton.getBottomHeight(false) + btnHeight / 2; } else { centerAnimY = visibleFrame.height() - shineButton.getBottomHeight(true) + btnHeight / 2; } } else { centerAnimY = location[1] + btnHeight / 2; } No problems have been found so far.

lodgkk avatar Apr 22 '19 05:04 lodgkk

Resolved this issue?

carlosalexandresmo avatar Jun 14 '19 03:06 carlosalexandresmo

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone. bottomHeight = metrics.heightPixels - location[1];

This is correct, my device is rooted and customized. I force it to fullscreen so that navigation and status bar are both immersive. By that the shine and ring was out of the position.

ArcherEmiya05 avatar Jun 18 '19 03:06 ArcherEmiya05

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone. bottomHeight = metrics.heightPixels - location[1];

This is correct, my device is rooted and customized. I force it to fullscreen so that navigation and status bar are both immersive. By that the shine and ring was out of the position.

Should you use 1.0.0 version to test this problem?I changed calculate location method.

ChadCSong avatar Jun 20 '19 03:06 ChadCSong

This is not a problem with Android p, but a problem with a full-screen phone, failing to get the exact height of a full-screen phone. bottomHeight = metrics.heightPixels - location[1];

This is correct, my device is rooted and customized. I force it to fullscreen so that navigation and status bar are both immersive. By that the shine and ring was out of the position.

Should you use 1.0.0 version to test this problem?I changed calculate location method.

I tested it on Android P. I was having this problem before since I hid the navigation bar. Your fix works! Thank you very much.

anhtuan23 avatar Jun 22 '19 12:06 anhtuan23