zencoder-cs icon indicating copy to clipboard operation
zencoder-cs copied to clipboard

Published 20 hours ago • verified publisher icon ChadBurggraf

Add Grouping Support to CreateJob

Open getopenwater opened this issue 12 years ago • 3 comments

getopenwater avatar Apr 29 '13 15:04 getopenwater

I'm cool with this and appreciate the addition. However, can you remove the changes to Zencoder.cs? They break the public API and will cause build errors for anyone calling Zencoder.CreateJob (the tests project doesn't actually build with the PR applied).

ChadBurggraf avatar Apr 29 '13 15:04 ChadBurggraf

Sorry that was my mistake. I just added app.config so I could also run the test project.

I added a new overload to handle grouping. Is that okay?

getopenwater avatar Apr 29 '13 15:04 getopenwater

I was just implementing this, I need PassThrough as well though, so I'll work in my local copy until this is merged in, then I'll update, add my passthrough, and put up a patch for PassThrough support

agrath avatar Jun 07 '13 04:06 agrath