cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Classification Type demo confusing.

Open mramato opened this issue 5 years ago • 4 comments

I'm not sure when we added a yellow polyline to the classification types demo, but it's not obvious why it's there or what it's doing.

At first I thought it was a bug then I assumed it was added to show how classification affects things.

However, for classify both but it again, has odd behavior where the line is doubled:

image

And I have no idea if this is correct behavior or not because there's no explanation in the Sandcastle about what any of this is.

CC @OmarShehata this goes along with the discussions we've been having about quality and understandably of the examples and a good one to use for discussion/evaluation.

mramato avatar Oct 01 '20 17:10 mramato

@mramato I'm taking a look at this issue right now! The demo contains both a Cesium World Terrain object and a 3D Tileset (with only a single tile), and I think that it is meant to show how you can restrict where an entity appears, whether its only on the terrain, or only on the tile. This is why there are duplicate polylines; when you have "Classify Both" selected in the dropdown it draws on both the 3d tile and the terrain right below it. Does this behavior make more sense in this context?

j9liu avatar Jun 07 '21 16:06 j9liu

@mramato - just bumping this in case you missed the notification last week!

j9liu avatar Jun 14 '21 19:06 j9liu

@j9liu While I understand what is happening, I still think the overall demo would be very confusing to new users. In reality, we need to majorly rethink all of our existing Sandcastle demos. A short term solution would be to add a code comment to the example explaining what the user is seeing and what this is demonstrating, but the "both draws under the tile and on the ground too" is more a bug than a feature.

It might be better to just leave this issue until we are ready to revisit Sandcastle examples cesium-wide.

mramato avatar Jun 14 '21 19:06 mramato

@mramato - got it, I can leave it alone for now

j9liu avatar Jun 14 '21 19:06 j9liu