cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Rectangle.validate is a no-op

Open mramato opened this issue 9 years ago • 5 comments

It looks like Rectangle.validate has it's entire implementation wrapped inside of a pragma, but the function itself is exposed and documented. This means if our users call Rectangle.validate nothing will ever happen. We have two chocies

  1. Rectangle.validate should not pragma out it's implementation
  2. Rectangle.validate should be marked private and removed from the API
  3. Add Rectangle.devValidate which we use internally and does pragma out, but make Rectangle.validate always perform checks.

For simplicity, I would go with 1, but if @pjcozzi or @bagnell thinks this will lead to major performance issues, we should do 3.

mramato avatar Jan 25 '17 19:01 mramato

Probably 2, but will evaluate when it is a priority.

pjcozzi avatar Jan 25 '17 21:01 pjcozzi

I'll take this one.

hotpocket avatar Aug 26 '24 23:08 hotpocket

@hotpocket Got it!

ggetz avatar Aug 26 '24 23:08 ggetz

I have submitted a pull request. The fix seems too simple, so let me know if I've missed something obvious. Thanks!

hotpocket avatar Sep 23 '24 22:09 hotpocket

#12212 has been merged which deprecates Rectangle.validate. This should now be fully removed in 1.124

jjspace avatar Sep 27 '24 20:09 jjspace