Rectangle.validate is a no-op
It looks like Rectangle.validate has it's entire implementation wrapped inside of a pragma, but the function itself is exposed and documented. This means if our users call Rectangle.validate nothing will ever happen. We have two chocies
-
Rectangle.validateshould not pragma out it's implementation -
Rectangle.validateshould be marked private and removed from the API - Add
Rectangle.devValidatewhich we use internally and does pragma out, but makeRectangle.validatealways perform checks.
For simplicity, I would go with 1, but if @pjcozzi or @bagnell thinks this will lead to major performance issues, we should do 3.
Probably 2, but will evaluate when it is a priority.
I'll take this one.
@hotpocket Got it!
I have submitted a pull request. The fix seems too simple, so let me know if I've missed something obvious. Thanks!
#12212 has been merged which deprecates Rectangle.validate. This should now be fully removed in 1.124