Fix #9393: Consistent _buttonDown usage in ScreenSpaceEventHandler.js
Changes made to _buttonDown in ScreenSpaceEventHandler.js
Thank you for the pull request, @ayushd150! Welcome to the Cesium community!
In order for us to review your PR, please complete the following steps:
- [x] Send in a Contributor License Agreement (CLA)
- [x] Add yourself to the contributors file
Review Pull Request Guidelines to make sure your PR gets accepted quickly.
I have signed the CLA in Google Forms
Added myself in the Contributors.md file
Thanks @ayushd150!
First things first, could you let us know the reason for the change? It looks like this may be a fix for https://github.com/CesiumGS/cesium/issues/9393, is that correct?
If we do want to move forward with this PR–
- I can confirm we now have a CLA on file for you.
- Could you please pull your change from https://github.com/CesiumGS/cesium/pull/12614 into this branch so we can review everything together?
I went ahead and pushed the changes from my comment above so we can try and get this merged. @lukemckinstry or @mzschwartz5 would you be able to take a quick look at this and merge if happy? You can check https://github.com/CesiumGS/cesium/issues/9393 for some context
I went ahead and pushed the changes from my comment above so we can try and get this merged. @lukemckinstry or @mzschwartz5 would you be able to take a quick look at this and merge if happy? You can check #9393 for some context
I'll take a look