cesium icon indicating copy to clipboard operation
cesium copied to clipboard
verified publisher icon CesiumGS

Splat shader Fix: Unable to obtain the position on the model using pickPosition when loading 3dgs Gaussian data

Open yuqingyang0129 opened this issue 11 months ago • 7 comments

Description

Issue number and link

Testing plan

Author checklist

  • [ ] I have submitted a Contributor License Agreement
  • [ ] I have added my name to CONTRIBUTORS.md
  • [ ] I have updated CHANGES.md with a short summary of my change
  • [ ] I have added or updated unit tests to ensure consistent code coverage
  • [ ] I have updated the inline documentation, and included code examples where relevant
  • [ ] I have performed a self-review of my code

yuqingyang0129 avatar Mar 31 '25 10:03 yuqingyang0129

Thank you for the pull request, @h5developers! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

github-actions[bot] avatar Mar 31 '25 10:03 github-actions[bot]

Thanks for the suggestion @h5developers.

@keyboardspecialist Would you mind taking a pass on this PR and decide if you would like to incorporate it into your branch?

ggetz avatar Mar 31 '25 17:03 ggetz

Yes, this is a change we already discussed making. This is necessary for not only picking, but for occlusion with other objects in the scene.

keyboardspecialist avatar Mar 31 '25 18:03 keyboardspecialist

@h5developers I don't think we have a CLA on file for you. We need one to merge this PR. Could you please send in a Contributor License Agreement (CLA)?

ggetz avatar Apr 01 '25 14:04 ggetz

Hi @yuqingyang0129, I dropped a comment in https://github.com/CesiumGS/cesium/pull/12545. Could you please make the CONTRIBUTORS.md update in this branch?

ggetz avatar Apr 11 '25 20:04 ggetz

@keyboardspecialist Is this still applicable given the new PR https://github.com/CesiumGS/cesium/pull/12582? If so, we can get this cleaned up and retargeted.

if not, we'll close.

ggetz avatar Apr 30 '25 17:04 ggetz

@keyboardspecialist Is this still applicable given the new PR #12582? If so, we can get this cleaned up and retargeted.

if not, we'll close.

yes , and I have [Update CONTRIBUTORS.md]

yuqingyang0129 avatar May 19 '25 12:05 yuqingyang0129

@keyboardspecialist Could you please check if this PR is needed now that your PR has been merged?

ggetz avatar Jul 23 '25 19:07 ggetz