cesium icon indicating copy to clipboard operation
cesium copied to clipboard

feat: Introduce `SampledProperty` new function `getSample`

Open s3xysteak opened this issue 1 year ago • 2 comments

Description

The PR add a new function getSample to SampledProperty, which provides a feature to get the time of samples by index.

Issue number and link

Closes #12245.

Testing plan

Technically speaking, it only performs simple operations on arrays. I add a simple unit test to check if it works well.

Author checklist

  • [x] I have submitted a Contributor License Agreement
  • [x] I have added my name to CONTRIBUTORS.md
  • [x] I have updated CHANGES.md with a short summary of my change
  • [x] I have added or updated unit tests to ensure consistent code coverage
  • [x] I have updated the inline documentation, and included code examples where relevant
  • [x] I have performed a self-review of my code

s3xysteak avatar Oct 15 '24 11:10 s3xysteak

Thank you for the pull request, @s3xysteak!

:white_check_mark: We can confirm we have a CLA on file for you.

github-actions[bot] avatar Oct 15 '24 11:10 github-actions[bot]

Thanks for the PR @s3xysteak!

@lukemckinstry Could you please review?

ggetz avatar Oct 15 '24 19:10 ggetz

@s3xysteak I noticed that there hasn't been any updates on this recently. Are you still planning on moving forward with this PR in the near future? If not, I'll close this for now to keep things tidy.

ggetz avatar Nov 15 '24 16:11 ggetz

@s3xysteak Please resolve any conflicts tithe the main branch, and ensure you're changes are listed in CHANGES.md under the next release: 1.124.

ggetz avatar Nov 18 '24 16:11 ggetz

Looks great! Thanks @s3xysteak!

ggetz avatar Nov 20 '24 17:11 ggetz