cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Geocoder click to trigger search event

Open Patsnoop opened this issue 1 year ago • 1 comments

Description

I added a command to make clicking on a suggestion and pressing the enter key react the same

Issue number and link

Fixes #6313 - GeocoderViewModel.search command not executed when user clicks a suggestion - https://github.com/CesiumGS/cesium/issues/6313

Testing plan

I ran the program locally and tested the changes on my machine

Author checklist

  • [X] I have submitted a Contributor License Agreement
  • [X] I have added my name to CONTRIBUTORS.md
  • [X] I have updated CHANGES.md with a short summary of my change
  • [X] I have added or updated unit tests to ensure consistent code coverage
  • [X] I have updated the inline documentation, and included code examples where relevant
  • [X] I have performed a self-review of my code

Patsnoop avatar Sep 23 '24 23:09 Patsnoop

Thank you for the pull request, @Patsnoop!

:white_check_mark: We can confirm we have a CLA on file for you.

github-actions[bot] avatar Sep 23 '24 23:09 github-actions[bot]

@Patsnoop Do you have interest in getting this PR over the finish line?

ggetz avatar Oct 29 '24 14:10 ggetz

@ggetz Good Afternoon, I do plan on finishing this up. I will make some time this weekend to work on it and resubmit.

Patsnoop avatar Oct 29 '24 22:10 Patsnoop

Awesome, thanks @Patsnoop!

ggetz avatar Oct 30 '24 13:10 ggetz

@Patsnoop I'm going to close this PR for now to keep things tidy.

Please feel free to re-submit the PR when ready! Thanks!

ggetz avatar Nov 15 '24 16:11 ggetz