cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Update `husky` hooks

Open jjspace opened this issue 1 year ago • 2 comments

Got a warning for git commit

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

I haven't looked into what exactly needs changed or what they're doing in v10 but we should prep for it before the update lands if possible

jjspace avatar Sep 03 '24 16:09 jjspace

I am not seeing this error currently when I run git commit. Do we know of specific conditions to reproduce it @jjspace?

lukemckinstry avatar Sep 26 '24 19:09 lukemckinstry

@lukemckinstry it's not an error, just a warning. If you're not in the CLI your git client may be hiding it. If you're using VSCode you can see it in the git output panel but that panel is very noisy so it's easy to miss it. Also please make sure you're using the latest version of husky, not sure if that matters but I assume it does.

From main:

git checkout -b testing-husky
touch test.js
git add .
git commit -m 'testing'
# see error

# to cleanup
git checkout main
git branch -D testing-husky

2024-09-26_16-42

jjspace avatar Sep 26 '24 20:09 jjspace