cesium icon indicating copy to clipboard operation
cesium copied to clipboard
verified publisher icon CesiumGS

Build an ISO compliant string - 11507

Open Alforoan opened this issue 1 year ago • 6 comments

Description

The function now properly converts the milliseconds into a fractional second with the specified precision, avoiding scientific notation.

Issue

Fixes https://github.com/CesiumGS/cesium/issues/11507

Testing plan

I ran the file and made sure it could run without bugs.

Author checklist

  • [ ] I have submitted a Contributor License Agreement
  • [x] I have added my name to CONTRIBUTORS.md
  • [x] I have updated CHANGES.md with a short summary of my change
  • [ ] I have added or updated unit tests to ensure consistent code coverage
  • [ ] I have updated the inline documentation, and included code examples where relevant
  • [x] I have performed a self-review of my code

Alforoan avatar Aug 26 '24 23:08 Alforoan

Thank you for the pull request, @Alforoan! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

github-actions[bot] avatar Aug 26 '24 23:08 github-actions[bot]

Thanks @Alforoan! I can confirm we have a CLA on file from you now.

ggetz avatar Aug 27 '24 13:08 ggetz

@jjspace Can you please review?

ggetz avatar Aug 27 '24 13:08 ggetz

Hi @Alforoan! Is the plan to still move forward with this PR? Do you need any additional help to get this over the finish line?

ggetz avatar Sep 20 '24 14:09 ggetz

Hi @Alforoan! Is the plan to still move forward with this PR? Do you need any additional help to get this over the finish line?

Hi yes

Alforoan avatar Sep 20 '24 16:09 Alforoan

@Alforoan Is this ready for another look?

ggetz avatar Oct 03 '24 13:10 ggetz

I'm closing this issue due to inactivity. If you believe this is still an issue, please feel free to re-open. Thanks!

ggetz avatar Oct 29 '24 13:10 ggetz