LICENSE.md contains non-existent link to NVIDIA GameWorks Graphics Samples project

[geekythoughts]

What happened?

The project's LICENSE.md file references the "NVIDIA GameWorks Graphics Samples" under third party code however, the referenced GitHub project no longer exists: https://github.com/NVIDIAGameWorks/GraphicsSamples

Given the referenced NVIDIA GameWorks graphics sample project no longer exists, the reference to this project and license should get removed. The existence of this license may raise concerns from users, developers, and organizations for using Cesium.

There's also a reference to the NVIDIA GameWorkds Graphics Samples project is found in in the following (relative) source: packages/engine/Source/Shaders/FXAA3_11.glsl#L3 however, the license content differs than the license contents listed within LICENSE.md.

Is this NVIDIA samples project still used or perhaps moved to another repo and can this discrepancy get resolved?

Reproduction steps

1. N/A - docuentation/license issue

...

Sandcastle example

No response

Environment

N/A - this is a documentation/licensing issue

[ggetz]

Thanks for the report @geekythoughts. We'll look into how much, if any, came from that project and be sure to update the licensing accordingly.

[javagl]

It looks like the license information was added in https://github.com/CesiumGS/cesium/commit/2d4a14fe0df12fbeb643ddad6a965e5296892c62#diff-51c9f7575ae3cdf8afeaf7fa1722e4a985df7a81b7b9520ddfd943a45299b7f4 (and only the link was changed a few years later).

The fact that NVIDIA pulled the rug under the GraphicsSamples is a bad practice in general. There are many links across the web that now lead to this 404. Why, oh why?

However, there seems to be a fork, with the file in question being found under this (hopefully 'perma'-) link: https://github.com/lyntel/GraphicsSamples/blob/3d30817ebeeade64fe6a4fc3aa1fe4265c29b6fd/samples/es3-kepler/FXAA/FXAA3_11.h

Based on the corresponding commits, it looks like only https://github.com/CesiumGS/cesium/blob/6f7077caeb0e0b7b78900660b2974bef267fd000/packages/engine/Source/Shaders/FXAA3_11.glsl has been taken from that. This single file carries an MIT header. This means that the current license statements in https://github.com/CesiumGS/cesium/blob/6f7077caeb0e0b7b78900660b2974bef267fd000/LICENSE.md#nvidia-gameworks-graphics-samples and https://github.com/CesiumGS/cesium/blob/6f7077caeb0e0b7b78900660b2974bef267fd000/packages/engine/LICENSE.md#nvidia-gameworks-graphics-samples can be removed, and replaced by the MIT header.

The link should be updated to the fork at https://github.com/lyntel/GraphicsSamples/blob/3d30817ebeeade64fe6a4fc3aa1fe4265c29b6fd/samples/es3-kepler/FXAA/FXAA3_11.h and - for completeness - maybe also the archive at https://archive.org/details/nvidiagame-works-graphics-samples-master