cesium
cesium copied to clipboard
Update to gulp 5
Description
Update to gulp 5.
This is opened as a draft because, while tasks are running, there's still problems. Right now, mainly with the tests.
- Bump gulp version
- Remove outdated
stream-to-promisein favor of the nativefinished - Remove
merge-stream, which does not appear to be maintained. The functionality can be replicated with the gulp API anyway. - Rearranged some sequential globs to ensure we're working with the new standard
- Passed
encoding: falsewhenever sourcing images or other binary files
Issue number and link
Fixes https://github.com/CesiumGS/cesium/issues/10919
Testing plan
- Ensure
make-zip,build-apps, andstarttask work - Ensure
testandtest-releasepass - Unzip release file
- Confirm release sandcastle and viewer app are unchanged
Author checklist
- [x] I have submitted a Contributor License Agreement
- [x] I have added my name to
CONTRIBUTORS.md - [ ] ~I have updated
CHANGES.mdwith a short summary of my change~ - [ ] ~I have added or updated unit tests to ensure consistent code coverage~
- [ ] ~I have update the inline documentation, and included code examples where relevant~
- [x] I have performed a self-review of my code
Thank you for the pull request, @ggetz!
:white_check_mark: We can confirm we have a CLA on file for you.
@jjspace Could you please review? The goal would be to get this in sometime this week to ensure it has some time in main before the release.
Thanks @jjspace! All your feedback should now be addressed.