cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Fix leaking CSS styling

Open ggetz opened this issue 1 year ago • 2 comments

Description

We ID'd some cases where the styling from packages/widgets/Source/I3SBuildingSceneLayerExplorer/I3SBuildingSceneLayerExplorer.css was affecting other styling in the page, particularly ul, input, and .active items.

This adds a top-level class for the wrapper element and ensures all styling is contained to the wrapper.

Issue number and link

N/A

Testing plan

  1. Check on previous appearance of the widget in https://sandcastle.cesium.com/?src=I3S%20Building%20Scene%20Layer.html. Make sure you select "Full Model" from the dropdown to see the whole panel contents.
  2. Ensure the updated version is styled the same
  3. Ensure other ul, input, and .active items in a page are not affected.

Author checklist

  • [x] I have submitted a Contributor License Agreement
  • [x] I have added my name to CONTRIBUTORS.md
  • [x] I have updated CHANGES.md with a short summary of my change
  • [ ] ~I have added or updated unit tests to ensure consistent code coverage~
  • [ ] ~I have update the inline documentation, and included code examples where relevant~
  • [x] I have performed a self-review of my code

ggetz avatar Apr 26 '24 18:04 ggetz

@jjspace Could you please take a look?

ggetz avatar Apr 26 '24 18:04 ggetz

Thank you for the pull request, @ggetz!

:white_check_mark: We can confirm we have a CLA on file for you.

github-actions[bot] avatar Apr 26 '24 18:04 github-actions[bot]