cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Reconsider Classification Approach

Open ggetz opened this issue 2 years ago • 5 comments

Feature

Coming out of https://github.com/CesiumGS/cesium/issues/11341, we noted that there are several limitations of the current classification implementation, including the need for watertight classification volumes, performance issues, transparency issues, and invert classification artifacts.

I've attempted to capture a running list of these with the Classification label.

@lilleyse Has a few longer-term ideas for an improved approach, including taking advantage of WebGPU features like image load/store to do per-pixel linked lists.

ggetz avatar Jan 05 '24 14:01 ggetz

so do cesium team have any progress on this?

jiangheng90 avatar Sep 18 '24 09:09 jiangheng90

@jiangheng90 There hasn't been any activity on this yet.

If you'd like to add more information about your use case, that may help us prioritize. If you are interesting in contributing, please let us know and we'd be happy to discuss implementation or review a PR. Thanks!

ggetz avatar Sep 18 '24 13:09 ggetz

@jiangheng90 There hasn't been any activity on this yet.

If you'd like to add more information about your use case, that may help us prioritize. If you are interesting in contributing, please let us know and we'd be happy to discuss implementation or review a PR. Thanks!

I'm interesting in contributing. recently I will review this issue list first. and see what I can do..

jiangheng90 avatar Sep 18 '24 14:09 jiangheng90

@ggetz I have seen the issue of #9419 today, I found the problem is comes from the oit.

so I think what if I add a pass to split the translucent 3dtiles and translucent normal primitive.

In current version, the translucent normal primitive and 3dtiles is excuted in one pass and u can not tell the different type.

I wonder if new draw order is translucent 3dtiles -> translucent tile classification -> translucent primitive all in oit buffer

then composite in oit. In this way u can fix this issue in a very low cost.

but in a long term. I think the drawcommand design will be more and more complecated when one unexpected issue comes out. I think terrain, 3dtiles, normal primitive drawcommd needs a uniform process for shadow, classification, translucent feature...

jiangheng90 avatar Sep 19 '24 10:09 jiangheng90

Thanks @jiangheng90! @lilleyse would you be able to comment on the suggested approach here?

ggetz avatar Sep 19 '24 21:09 ggetz