cesium
cesium copied to clipboard
Remove "ThirdParty/mersenne-twister.js"
we should import mersenne-twister directly from node_modules. https://github.com/CesiumGS/cesium/issues/10568
Thanks for the pull request @nshen!
- :heavy_check_mark: Signed CLA found.
- :grey_question: CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to
CHANGES.md
.
- If this change updates the public API in any way, please add a bullet point to
- :grey_question: Changes to third party files were made.
- Looks like a file in one of our ThirdParty folders (
ThirdParty/, Source/ThirdParty/
) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.
- Looks like a file in one of our ThirdParty folders (
- :grey_question: Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.
Reviewers, don't forget to make sure that:
- [ ] Cesium Viewer works.
- [ ] Works in 2D/CV.
Thanks @nshen! I can confirm these changes are working. Does this resolve https://github.com/nshen/vite-plugin-cesium/issues/34?
I'll try https://github.com/nshen/vite-plugin-cesium/issues/34 when all ThirdParty removed