cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Remove "ThirdParty/mersenne-twister.js"

Open nshen opened this issue 1 year ago • 1 comments

we should import mersenne-twister directly from node_modules. https://github.com/CesiumGS/cesium/issues/10568

nshen avatar Aug 09 '22 18:08 nshen

Thanks for the pull request @nshen!

  • :heavy_check_mark: Signed CLA found.
  • :grey_question: CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • :grey_question: Changes to third party files were made.
    • Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.
  • :grey_question: Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • [ ] Cesium Viewer works.
  • [ ] Works in 2D/CV.

cesium-concierge avatar Aug 09 '22 18:08 cesium-concierge

Thanks @nshen! I can confirm these changes are working. Does this resolve https://github.com/nshen/vite-plugin-cesium/issues/34?

ggetz avatar Aug 11 '22 14:08 ggetz

I'll try https://github.com/nshen/vite-plugin-cesium/issues/34 when all ThirdParty removed

nshen avatar Aug 11 '22 16:08 nshen