cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Published 20 hours ago • verified publisher icon CesiumGS

Add ModelAnimation.startOffset

Open srcejon opened this issue 2 years ago • 3 comments

As per #10042, this PR adds ModelAnimation.startOffset, which allows specifying at what point an animation starts playing from.

srcejon avatar Jan 27 '22 10:01 srcejon

Thanks for the pull request @srcejon!

  • :heavy_check_mark: Signed CLA found.
  • :grey_question: CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • :grey_question: Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • [ ] Cesium Viewer works.
  • [ ] Works in 2D/CV.

cesium-concierge avatar Jan 27 '22 10:01 cesium-concierge

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Apr 28 '22 02:04 cesium-concierge

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Jul 27 '22 02:07 cesium-concierge

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Oct 25 '22 02:10 cesium-concierge

I think that (in addition to needing fixes to make it work properly, as I mentioned above) this can be trivially handled using ModelAnimation.animationTime as provided by #9339, so is no longer needed.

markw65 avatar Oct 25 '22 14:10 markw65

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Jan 24 '23 03:01 cesium-concierge

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Apr 24 '23 02:04 cesium-concierge

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Jul 23 '23 02:07 cesium-concierge

I'm closing this due to inactivity. If you believe this is still an issue, please feel free to re-open and we'll give this a fresh review. Thanks!

ggetz avatar Aug 25 '23 13:08 ggetz